This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
fix some of the pylint errors #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint highlighted issues with the duplication of the choose_workflows function so I removed the function from the project.py as we didn't use it in the tutorials and we already have one "choose_workflow" function in zooniverse_utils.
victor-wildlife
changed the title
Diewertje11
force-pushed
the
pylint-test
branch
from
22fd6a1 to
861a450
Compare
|
Great! Thank you for this. I have cherry-picked all the fix commits, so they are implemented in the branch pylint-test and in MR #166. The other ones that change something to the logging was something I had already changed before (and it does not give any errors anymore), and I also do not get any black errors there, so I did not pick these. So I will close this pull request. If you have more commits that solve other errors, you can just add it here and reopen it again. Then I will cherry pick the new ones. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint highlighted issues with a few utils so here are some fixes