fix bug about comparing key in ob_compaction_test #546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In MiniOB, a
key
consists of aninternal key
followed by aseq
component. When checking for overlapping keys in a sorted run, we should sort and compare based on theinternal key
only. This is typically done by using theinternal key
as the sorting index and then comparing the last key of the previous SSTable with the first key of the current one.However, if the full
key
(includingseq
) is used as the sorting index, theseq
component will incorrectly influence the result of the overlap check, potentially leading to false negatives or positives.What is changed and how it works?
This PR replaces direct string comparison with the
obInternalKeyComparator
to sort and compare keys correctly, ensuring that only theinternal key
is considered during overlap checks.Other information