chore: add more accurate error log when the resource cannot be found

internal/cli/backup/delete.go

@@ -15,7 +15,7 @@ package backup
 
 import (
 	"context"
-	"errors"
+	"fmt"
 
 	"github.com/spf13/cobra"
 	"k8s.io/apimachinery/pkg/types"
@@ -37,7 +37,7 @@ func DeleteTenantBackupPolicy(ctx context.Context, o *DeleteOptions) error {
 	nn := types.NamespacedName{Name: o.Name, Namespace: o.Namespace}
 	policy, err := clients.GetTenantBackupPolicy(ctx, nn)
 	if policy == nil {
-		return errors.New("Backup policy not found for the tenant")
+		return fmt.Errorf("Backup policy for %s not found", o.Name)
 	}
 	if err != nil {
 		return err

internal/cli/backup/update.go

@@ -20,6 +20,7 @@ import (
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/generic"
@@ -48,6 +49,9 @@ func UpdateTenantBackupPolicy(ctx context.Context, o *UpdateOptions) error {
 	}
 	obtenant, err := clients.GetOBTenant(ctx, nn)
 	if err != nil {
+		if kubeerrors.IsNotFound(err) {
+			return errors.New("tenant not found")
+		}
 		return err
 	}
 	if err := utils.CheckTenantStatus(obtenant); err != nil {

internal/cli/cmd/cluster/delete.go

@@ -15,6 +15,7 @@ package cluster
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 
 	cluster "github.com/oceanbase/ob-operator/internal/cli/cluster"
 	"github.com/oceanbase/ob-operator/internal/cli/utils"
@@ -33,7 +34,11 @@ func NewDeleteCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			err := clients.DeleteOBCluster(cmd.Context(), o.Namespace, o.Name)
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBCluster %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			logger.Printf("Delete OBCluster %s successfully", o.Name)
 		},

internal/cli/cmd/cluster/scale.go

@@ -15,6 +15,7 @@ package cluster
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 
 	cluster "github.com/oceanbase/ob-operator/internal/cli/cluster"
 	"github.com/oceanbase/ob-operator/internal/cli/utils"
@@ -34,7 +35,11 @@ func NewScaleCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			obcluster, err := clients.GetOBCluster(cmd.Context(), o.Namespace, o.Name)
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBCluster %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckClusterStatus(obcluster); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/cluster/show.go

@@ -17,6 +17,7 @@ import (
 	"sort"
 
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 
 	"github.com/oceanbase/ob-operator/internal/cli/cluster"
 	"github.com/oceanbase/ob-operator/internal/cli/utils"
@@ -36,7 +37,11 @@ func NewShowCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			obcluster, err := clients.GetOBCluster(cmd.Context(), o.Namespace, o.Name)
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBCluster %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			obclusterOperationList, err := clients.GetOBClusterOperations(cmd.Context(), obcluster)
 			if err != nil {

internal/cli/cmd/cluster/update.go

@@ -15,6 +15,7 @@ package cluster
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 
 	cluster "github.com/oceanbase/ob-operator/internal/cli/cluster"
 	"github.com/oceanbase/ob-operator/internal/cli/utils"
@@ -40,7 +41,11 @@ func NewUpdateCmd() *cobra.Command {
 			}
 			obcluster, err := clients.GetOBCluster(cmd.Context(), o.Namespace, o.Name)
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBCluster %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckClusterStatus(obcluster); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/cluster/upgrade.go

@@ -15,6 +15,7 @@ package cluster
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 
 	cluster "github.com/oceanbase/ob-operator/internal/cli/cluster"
 	"github.com/oceanbase/ob-operator/internal/cli/utils"
@@ -37,7 +38,11 @@ func NewUpgradeCmd() *cobra.Command {
 			}
 			obcluster, err := clients.GetOBCluster(cmd.Context(), o.Namespace, o.Name)
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBCluster %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckClusterStatus(obcluster); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/activate.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	apiconst "github.com/oceanbase/ob-operator/api/constants"
@@ -41,7 +42,11 @@ func NewActivateCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/changepwd.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -40,7 +41,11 @@ func NewChangePwdCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/delete.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -37,7 +38,11 @@ func NewDeleteCmd() *cobra.Command {
 				Name:      o.Name,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			logger.Printf("Delete OBTenant %s successfully", o.Name)
 		},

internal/cli/cmd/tenant/replaylog.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	apiconst "github.com/oceanbase/ob-operator/api/constants"
@@ -38,7 +39,11 @@ func NewReplayLogCmd() *cobra.Command {
 				Name:      o.Name,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/scale.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -38,7 +39,11 @@ func NewScaleCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/show.go

@@ -17,6 +17,7 @@ import (
 	"sort"
 
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -40,7 +41,11 @@ func NewShowCmd() *cobra.Command {
 				Name:      o.Name,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			obtenantOperationList, err := clients.GetOBTenantOperations(cmd.Context(), obtenant)
 			if err != nil {

internal/cli/cmd/tenant/switchover.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	apiconst "github.com/oceanbase/ob-operator/api/constants"
@@ -41,7 +42,11 @@ func NewSwitchOverCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.StandbyTenant)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(standbyTenant); err != nil {
 				logger.Fatalln(err)
@@ -54,7 +59,11 @@ func NewSwitchOverCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.PrimaryTenant)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(primaryTenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/update.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -38,7 +39,11 @@ func NewUpdateCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/cmd/tenant/upgrade.go

@@ -15,6 +15,7 @@ package tenant
 
 import (
 	"github.com/spf13/cobra"
+	kubeerrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 
 	"github.com/oceanbase/ob-operator/internal/cli/tenant"
@@ -41,7 +42,11 @@ func NewUpgradeCmd() *cobra.Command {
 				Namespace: o.Namespace,
 			})
 			if err != nil {
-				logger.Fatalln(err)
+				if kubeerrors.IsNotFound(err) {
+					logger.Fatalf("OBTenant %s not found", o.Name)
+				} else {
+					logger.Fatalln(err)
+				}
 			}
 			if err := utils.CheckTenantStatus(obtenant); err != nil {
 				logger.Fatalln(err)

internal/cli/update/update.go

@@ -40,8 +40,6 @@ func (o *UpdateOptions) Parse(_ *cobra.Command, args []string) error {
 		components := config.GetAllComponents()
 		// check if the component is supported
 		defaultVersion, exist := components[name]
-
-		// check if the component is supported
 		if !exist {
 			return fmt.Errorf("component %s is not supported", name)
 		}