Skip to content

Commit

Permalink
fix: optionalize obtenant.spec.credentials
Browse files Browse the repository at this point in the history
  • Loading branch information
powerfooI committed Oct 9, 2023
1 parent 24edf80 commit 21b7036
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/obtenant_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type OBTenantSpec struct {
//+kubebuilder:default=PRIMARY
TenantRole apitypes.TenantRole `json:"tenantRole,omitempty"`
Source *TenantSourceSpec `json:"source,omitempty"`
Credentials TenantCredentials `json:"credentials"`
Credentials TenantCredentials `json:"credentials,omitempty"`
}

type TenantCredentials struct {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ spec:
unitNum:
type: integer
required:
- credentials
- obcluster
- pools
- tenantName
Expand Down Expand Up @@ -766,7 +765,6 @@ spec:
unitNum:
type: integer
required:
- credentials
- obcluster
- pools
- tenantName
Expand Down
1 change: 0 additions & 1 deletion config/crd/bases/oceanbase.oceanbase.com_obtenants.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ spec:
unitNum:
type: integer
required:
- credentials
- obcluster
- pools
- tenantName
Expand Down
2 changes: 1 addition & 1 deletion pkg/oceanbase/operation/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func (m *OceanbaseOperationManager) SetLogArchiveDestState(state string) error {
}

func (m *OceanbaseOperationManager) SetLogArchiveConcurrency(concurrency int) error {
return m.SetParameter("log_archive_concurrency", concurrency, nil)
return m.SetParameter("LOG_ARCHIVE_CONCURRENCY", concurrency, nil)
}

func (m *OceanbaseOperationManager) SetDataBackupDestForTenant(uri string) error {
Expand Down

0 comments on commit 21b7036

Please sign in to comment.