Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(todo): removed two TODOs cause they are finished
Browse files Browse the repository at this point in the history
powerfooI committed Sep 5, 2024
1 parent effdbb6 commit 5ea2795
Showing 2 changed files with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -191,7 +191,6 @@ func (m *ObTenantBackupPolicyManager) UpdateStatus() error {
}
var backupPath string
if m.BackupPolicy.Spec.DataBackup.Destination.Type != constants.BackupDestTypeNFS {
// TODO: check if &s3_region=? part should be removed
backupPath = m.BackupPolicy.Spec.DataBackup.Destination.Path
} else {
backupPath = m.getDestPath(m.BackupPolicy.Spec.DataBackup.Destination)
Original file line number Diff line number Diff line change
@@ -219,7 +219,6 @@ func StopBackup(m *ObTenantBackupPolicyManager) tasktypes.TaskError {
func CheckAndSpawnJobs(m *ObTenantBackupPolicyManager) tasktypes.TaskError {
var backupPath string
if m.BackupPolicy.Spec.DataBackup.Destination.Type != constants.BackupDestTypeNFS {
// TODO: check if &s3_region=? part should be removed
backupPath = m.BackupPolicy.Spec.DataBackup.Destination.Path
} else {
backupPath = m.getDestPath(m.BackupPolicy.Spec.DataBackup.Destination)

0 comments on commit 5ea2795

Please sign in to comment.