Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bugs found in smoke testing #207

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Fix some bugs found in smoke testing #207

merged 7 commits into from
Feb 26, 2024

Conversation

powerfooI
Copy link
Collaborator

@powerfooI powerfooI commented Feb 21, 2024 •
edited
Loading

Summary

  1. Fixed bug that leads to empty-name OBTenantOperation
  2. Fixed unmatched namespace and name in creating backup policy
  3. Updated types and demonstrations of fields and generate swagger docs
  4. Updated API URL prefix of OBTenant group from obtenant to obtenants

@powerfooI powerfooI self-assigned this Feb 21, 2024
@powerfooI powerfooI force-pushed the fix/dashboard-backup branch from ea7ef25 to 133f9d4 Compare February 22, 2024 03:47
@powerfooI powerfooI force-pushed the fix/dashboard-backup branch from e3d7c1f to 4043a7a Compare February 23, 2024 02:42
chris-sun-star
chris-sun-star reviewed Feb 26, 2024
View reviewed changes
distribution/dashboard/internal/model/param/backup_param.go Outdated
JobKeepWindow string `json:"jobKeepWindow,omitempty"`
RecoveryWindow string `json:"recoveryWindow,omitempty"`
PieceInterval string `json:"pieceInterval,omitempty"`
JobKeepWindow int `json:"jobKeepWindow,omitempty" example:"5"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'd like to use int for days, at least reflect it in parameter name. jobKeepWindow -> jobKeepWindowDays

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've renamed them to xxxDays to get more deterministic.

chris-sun-star
chris-sun-star approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@chris-sun-star chris-sun-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to make other changes, create a new PR next time

@chris-sun-star chris-sun-star merged commit cffd203 into oceanbase:master Feb 26, 2024
4 checks passed
@powerfooI powerfooI deleted the fix/dashboard-backup branch March 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

Assignees

@powerfooI powerfooI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerfooI @chris-sun-star