-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource labels; Coordinate when sub-resource changes #212
Add resource labels; Coordinate when sub-resource changes #212
Conversation
… to accelerate reconciling
@@ -97,6 +97,7 @@ func (r *OBClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( | |||
func (r *OBClusterReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
return ctrl.NewControllerManagedBy(mgr). | |||
For(&v1alpha1.OBCluster{}). | |||
Owns(&v1alpha1.OBZone{}).Owns(&v1alpha1.OBParameter{}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only obzone is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I have resolved it.
LabelTenantName = "oceanbase.oceanbase.com/tenant-name" | ||
LabelBackupType = "oceanbase.oceanbase.com/backup-type" | ||
LabelTenantName = "oceanbase.oceanbase.com/tenant-name" | ||
LabelSecondTenant = "oceanbase.oceanbase.com/second-tenant" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second -> secondary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
paused
status