Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource labels; Coordinate when sub-resource changes #212

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

powerfooI
Copy link
Collaborator

Summary

  1. Fixed the bug that backup policy cannot be deleted in paused status
  2. Added reconciliation for OBCluster and OBZone when sub-resource changes, closed [Enhancement]: Accelerate resource schedule when sub-resource changed #199
  3. Added necessary labels for tenant operation and tenant
  4. Fixed the bug that backup policy uses tenantName in database instead of CR name of OBTenant in its labels

@powerfooI powerfooI self-assigned this Feb 27, 2024
@powerfooI powerfooI changed the title Fix/resource labels Add resource labels; Coordinate when sub-resource changes Feb 27, 2024
@@ -97,6 +97,7 @@ func (r *OBClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
func (r *OBClusterReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
For(&v1alpha1.OBCluster{}).
Owns(&v1alpha1.OBZone{}).Owns(&v1alpha1.OBParameter{}).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only obzone is needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have resolved it.

LabelTenantName = "oceanbase.oceanbase.com/tenant-name"
LabelBackupType = "oceanbase.oceanbase.com/backup-type"
LabelTenantName = "oceanbase.oceanbase.com/tenant-name"
LabelSecondTenant = "oceanbase.oceanbase.com/second-tenant"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second -> secondary ?

Copy link
Member

@chris-sun-star chris-sun-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-sun-star chris-sun-star merged commit bc62619 into oceanbase:master Feb 28, 2024
4 checks passed
@powerfooI powerfooI deleted the fix/resource-labels branch March 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Accelerate resource schedule when sub-resource changed
2 participants