Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tasks and flows in OBCluster package #249

Merged
merged 13 commits into from
Mar 21, 2024
Merged

Refactor tasks and flows in OBCluster package #249

merged 13 commits into from
Mar 21, 2024

Conversation

powerfooI
Copy link
Collaborator

Summary

  1. Split const/oceanbase/oceanbase.go to several go files
  2. Refactored flow and task module, added generators to register them to a specific resource, which introduce no new functional changes and should work like before, so the refactor could be performed progressively
  3. Added annotation for ignoring deletion, fixed [Enhancement]: Ignore deletion timestamp due to unintentional deletion #248

@powerfooI powerfooI self-assigned this Mar 19, 2024
chris-sun-star
chris-sun-star reviewed Mar 20, 2024
View reviewed changes
pkg/task/builder/task_builder.go Outdated Show resolved Hide resolved
make/development.mk Outdated Show resolved Hide resolved
cmd/generator/task/task-register.go Outdated Show resolved Hide resolved
@chris-sun-star chris-sun-star merged commit 496df7c into oceanbase:master Mar 21, 2024
4 checks passed
@powerfooI powerfooI deleted the optimize/task-and-flow branch June 19, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

Assignees

@powerfooI powerfooI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Ignore deletion timestamp due to unintentional deletion
2 participants
@powerfooI @chris-sun-star