Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs found in smoke test #355

Merged
merged 8 commits into from
May 8, 2024
Merged

Fixed bugs found in smoke test #355

merged 8 commits into from
May 8, 2024

Conversation

powerfooI
Copy link
Collaborator

Summary

  1. Added missing time.Second in timeout setting
  2. Waited a second before fetching a new job
  3. Added finalizer for obcluster with ignore-deletion annotation
  4. Collected finalizers into oceanbaseconst

@powerfooI powerfooI requested a review from chris-sun-star May 7, 2024 13:22
@powerfooI powerfooI self-assigned this May 7, 2024
@powerfooI powerfooI marked this pull request as draft May 8, 2024 06:05
@powerfooI powerfooI marked this pull request as ready for review May 8, 2024 07:36
@chris-sun-star chris-sun-star merged commit 5a9851f into oceanbase:master May 8, 2024
7 checks passed
@powerfooI powerfooI deleted the fix/test-2.2.1 branch May 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

Assignees

@powerfooI powerfooI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerfooI @chris-sun-star