add api definition for sql module of dashboard #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerfooI
reviewed
Sep 4, 2024
| } | ||
|
|
||
| type PlanStatistic struct { | ||
| PlanMeta |
There was a problem hiding this comment.
json:",inline" should be added to this line if the PlanMeta is expected to be included in response json.
| } | ||
|
|
||
| type PlanStatisticByServer struct { | ||
| PlanStatistic |
There was a problem hiding this comment.
The same as PlanMeta field in PlanStatistic, json tag should be added.
| } | ||
|
|
||
| type SqlInfo struct { | ||
| SqlMetaInfo |
There was a problem hiding this comment.
Missing JSON tag here too.
| } | ||
|
|
||
| type SqlFilter struct { | ||
| BaseSqlRequestParam |
There was a problem hiding this comment.
Missing json tag here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add api definition for sql module of dashboard
Solution Description