Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CI for oceanbase cli #570

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Conversation

lizzy-0323
Copy link
Contributor

@lizzy-0323 lizzy-0323 commented Sep 20, 2024

Summary

Add CI for oceanbase cli, update makefile for cli

This PR is associated with #131

Solution Description

@lizzy-0323 lizzy-0323 changed the title Feat obocli ci chore: Add CI for oceanbase cli Sep 20, 2024
@lizzy-0323 lizzy-0323 changed the title chore: Add CI for oceanbase cli chore: add CI for oceanbase cli Sep 20, 2024
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's not proper to release CLI tool as docker image. Archives (zip, tar etc.) for multiple platforms and installation script (e.g. install.sh) seem to be the common way to release similar tool.

@powerfooI
Copy link
Collaborator

For example, k3s could be installed easily by simply typing curl -sfL https://get.k3s.io | sh -s - --docker

Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 0e0696e into oceanbase:master Sep 25, 2024
7 checks passed
@lizzy-0323 lizzy-0323 deleted the feat-obocli-ci branch September 25, 2024 13:11
lizzy-0323 added a commit to lizzy-0323/ob-operator that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants