Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove alias in commands and add version injection for cli #582

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat: remove alias in commands and add version injection for cli #582

merged 3 commits into from
Oct 10, 2024

Conversation

lizzy-0323
Copy link
Contributor

Summary

  1. Remove alias in every command
  2. Add version injection for cli tool

Solution Description

powerfooI
powerfooI reviewed Oct 10, 2024
View reviewed changes
internal/cli/cmd/version/version.go Outdated Show resolved Hide resolved
make/cli.mk Outdated Show resolved Hide resolved
@lizzy-0323
Copy link
Contributor Author

The output when using version command are as follows:
image
image

powerfooI
powerfooI approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 85fbfdb into oceanbase:master Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerfooI powerfooI powerfooI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizzy-0323 @powerfooI