Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add timeout check for demo cmd #667

Merged
merged 4 commits into from
Dec 16, 2024
Merged

feat(cli): add timeout check for demo cmd #667

merged 4 commits into from
Dec 16, 2024

Conversation

lizzy-0323
Copy link
Contributor

Summary

Solution Description

powerfooI
powerfooI reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，but how to customize timeout duration?

@lizzy-0323
Copy link
Contributor Author

lizzy-0323 commented Dec 16, 2024 •
edited
Loading

LGTM，but how to customize timeout duration?

In my design, it's cmd.AddCommand(demo.NewCmd(0)), and if the timeout duration set to 0, then using the defaultTimeoutDuration. By this design, maybe we can set timeout duration by using variable injection in the future, which means setting this variable in config files.

@lizzy-0323
Copy link
Contributor Author

lizzy-0323 commented Dec 16, 2024 •
edited
Loading

After discussion, decide to use timeout duration as a flag, which is available for users to alter.

powerfooI
powerfooI approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit a82d783 into oceanbase:master Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerfooI powerfooI powerfooI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizzy-0323 @powerfooI