Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: annotations mask #98

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix: annotations mask #98

merged 2 commits into from
Nov 14, 2023

Conversation

powerfooI
Copy link
Collaborator

Summary

  • Set annotations of object to nil, avoiding possible sensitive telemetry frame
  • Make OBZone and OBCluster controller listen events of their owned resources. OBCluster controller listens events of OBZones, and OBCluster controller reacts when obzones change.

chris-sun-star
chris-sun-star approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@chris-sun-star chris-sun-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-sun-star chris-sun-star merged commit e5238ad into oceanbase:2.0.x_dev Nov 14, 2023
2 checks passed
@powerfooI powerfooI deleted the fix/telemetry-sentry branch November 14, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerfooI @chris-sun-star