Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GHA and run linkcheck #209

Open
wants to merge 4 commits into
base: source
Choose a base branch
from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 18, 2022

Update all GHA and runs link check to avoid link rot.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for oceanhackweek-preview ready!

Name Link
🔨 Latest commit 72e742f
🔍 Latest deploy log https://app.netlify.com/sites/oceanhackweek-preview/deploys/634f05ea55e94e0008cba507
😎 Deploy Preview https://deploy-preview-209--oceanhackweek-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 18, 2022

The following links are broken and we need replacements of fixes for them.

(about/task-groups:             line   16) broken    https://0.academia-photos.com/24329269/6755559/7629264/s200_denisse.fierro.jpg - 403 Client Error: Forbidden for url: https://0.academia-photos.com/24329269/6755559/7629264/s200_denisse.fierro.jpg
(ohw22/seattle/index:           line   67) broken    https://docs.google.com/presentation/d/17h4m6gTG8mRfWaQR3nOn6LPR3hQdCgWzH2hPzpCtyFU/edit#slide=id.p1 - Anchor 'slide=id.p1' not found
(resources/pandas:              line    9) broken    https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/pandas-intro.ipynb - 424 Client Error: Failed Dependency for url: https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/pandas-intro.ipynb
( resources/numpy:              line   13) broken    https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/numpy-intro.ipynb - 424 Client Error: Failed Dependency for url: https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/numpy-intro.ipynb
(resources/projects/guidelines: line   53) broken    https://oceanhackweek.github.io/projects.html - 404 Client Error: Not Found for url: https://oceanhackweek.github.io/projects.html
(ohw22/espanol/index.es:        line   14) broken    https://udelar.edu.uy/directorio/lugares/centro-universitario-regional-del-este-cure-sede-rocha-1/ - HTTPSConnectionPool(host='udelar.edu.uy', port=443): Max retries exceeded with url: /directorio/lugares/centro-universitario-regional-del-este-cure-sede-rocha-1/ (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)')))


The main page builder did not find any broken link for the changed ones. Maybe they are buried in other places.

@emiliom
Copy link
Member

emiliom commented Nov 8, 2022

Thanks @ocefpaf! This link checker will be very helpful.

(about/task-groups: line 16) broken https://0.academia-photos.com/24329269/6755559/7629264/s200_denisse.fierro.jpg - 403 Client Error: Forbidden for url: https://0.academia-photos.com/24329269/6755559/7629264/s200_denisse.fierro.jpg

I'll update this photo link very soon. 11/9: I've updated the photo link (#216 )

(ohw22/espanol/index.es: line 14) broken https://udelar.edu.uy/directorio/lugares/centro-universitario-regional-del-este-cure-sede-rocha-1/ - HTTPSConnectionPool(host='udelar.edu.uy', port=443): Max retries exceeded with url: /directorio/lugares/centro-universitario-regional-del-este-cure-sede-rocha-1/ (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)')))

This link is working. The error message is due to a SSL certificate validation failure. We could do nothing (ie, SSL validation failures will be exposed as errors), or alternatively, if possible, change the link checker to ignore SSL validation failures?

(ohw22/seattle/index: line 67) broken https://docs.google.com/presentation/d/17h4m6gTG8mRfWaQR3nOn6LPR3hQdCgWzH2hPzpCtyFU/edit#slide=id.p1 - Anchor 'slide=id.p1' not found

Hmm. This link is working. It's a Google slide presentation. Since the error involves the "Anchor 'slide=id.p1'", maybe removing "#slide=id.p1" from the url will make the link checker happy; I've verified that the link would still work. But I suspect that this is an issue that will be common with Google documents (docs/slides/sheets), so it may be a battle we can't win 🤔

The next 3 links involve pages that are not actively being used in the web site. Nothing links to them, though Sphinx still renders them. We could delete the pages, ignore the link errors, or tweak the pages. In the meantime, I made one easy change to resources/projects/guidelines (commented out the broken link) to silence the error.

(resources/pandas: line 9) broken https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/pandas-intro.ipynb - 424 Client Error: Failed Dependency for url: https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/pandas-intro.ipynb
( resources/numpy: line 13) broken https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/numpy-intro.ipynb - 424 Client Error: Failed Dependency for url: https://hub-binder.mybinder.ovh/user/uwescience-hack-inary-tutorials-e704wqfz/notebooks/notebooks/numpy-intro.ipynb
(resources/projects/guidelines: line 53) broken https://oceanhackweek.github.io/projects.html - 404 Client Error: Not Found for url: https://oceanhackweek.github.io/projects.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants