Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General update #38

Merged
merged 60 commits into from
Jul 24, 2023
Merged

General update #38

merged 60 commits into from
Jul 24, 2023

Conversation

balessan
Copy link
Collaborator

Fixes # Adding docker-compose, adding tests, adding integration of DBS_Arweave and DBS_Filecoin

@balessan
Copy link
Collaborator Author

Need to add some repository secrets for the tests to pass.

@balessan balessan closed this May 15, 2023
@balessan balessan reopened this May 15, 2023
@jamiehewitt15
Copy link
Member

There are quite a lot of changes here, can you share some more details about what issues they fix?

@balessan
Copy link
Collaborator Author

balessan commented Jul 12, 2023

@jamiehewitt15 :

I could have de facto merged it but I wanted the issues #39 and #40 to be clarified/answer before hand.

#39 would allow the unit tests to pass.
#40 would give my directions on how to close the remaining questions.

Let me know if it raises any questions.

@jamiehewitt15
Copy link
Member

Hi @balessan,

I tried running this but it's just giving me an HTML error page when I call the http://localhost:8000 endpoint. Is it working for you? I'm wondering if there is something wrong with my setup?

image

@balessan
Copy link
Collaborator Author

Hi @jamiehewitt15

It looks like the migrations are not run so the DB is not initialized. Is the build of the container ok ?
Can confirm it works on my side, I tried from scratch on yesterday while we were discussing.

Happy to take some time if screenshare is needed to understand.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update, I've managed to get it up and running. Let's merge this and then iterate further from the main branch with any alterations we need

@balessan balessan merged commit 0d80adb into oceanprotocol:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants