Skip to content

Commit

Permalink
Fix equality tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ocelotl committed Jun 27, 2024
1 parent 3c05700 commit df23d88
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ def test_synchronous_delta_temporality(self):
)
self.assertEqual(metric_data.min, self.test_values[index + 1])
self.assertEqual(metric_data.max, self.test_values[index + 1])
self.assertEqual(metric_data.sum, self.test_values[index + 1])
# Using assertAlmostEqual here because in 3.12 resolution can cause
# these checks to fail.
self.assertAlmostEqual(
metric_data.sum, self.test_values[index + 1]
)

results = []

Expand Down Expand Up @@ -200,7 +204,7 @@ def test_synchronous_cumulative_temporality(self):
self.assertEqual(
metric_data.max, max(self.test_values[: index + 2])
)
self.assertEqual(
self.assertAlmostEqual(
metric_data.sum, sum(self.test_values[: index + 2])
)

Expand Down Expand Up @@ -254,7 +258,7 @@ def test_synchronous_cumulative_temporality(self):
)
self.assertEqual(metric_data.min, min(self.test_values))
self.assertEqual(metric_data.max, max(self.test_values))
self.assertEqual(metric_data.sum, sum(self.test_values))
self.assertAlmostEqual(metric_data.sum, sum(self.test_values))

previous_metric_data = metric_data

Expand All @@ -272,7 +276,7 @@ def test_synchronous_cumulative_temporality(self):
)
self.assertEqual(previous_metric_data.min, metric_data.min)
self.assertEqual(previous_metric_data.max, metric_data.max)
self.assertEqual(previous_metric_data.sum, metric_data.sum)
self.assertAlmostEqual(previous_metric_data.sum, metric_data.sum)

self.assertEqual(
metric_data.positive.bucket_counts,
Expand Down

0 comments on commit df23d88

Please sign in to comment.