Skip to content

Commit

Permalink
Tests: Test marshalling compression only when enabled (#1651)
Browse files Browse the repository at this point in the history
  • Loading branch information
OlivierNicole authored Jul 30, 2024
1 parent 7221b9c commit 3a082a7
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 23 deletions.
13 changes: 12 additions & 1 deletion compiler/tests-jsoo/dune
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,21 @@
(preprocess
(pps ppx_expect)))

(library
(name jsoo_testsuite_compression)
(modules test_marshal_compressed)
(libraries unix compiler-libs.common js_of_ocaml-compiler)
(enabled_if
(>= %{ocaml_version} 5.1.1))
(inline_tests
(modes js best))
(preprocess
(pps ppx_expect)))

(library
(name jsoo_testsuite)
(modules
(:standard \ test_io test_floats))
(:standard \ test_io test_floats test_marshal_compressed))
(libraries unix compiler-libs.common js_of_ocaml-compiler)
(foreign_stubs
(language c)
Expand Down
22 changes: 0 additions & 22 deletions compiler/tests-jsoo/test_marshal.ml
Original file line number Diff line number Diff line change
Expand Up @@ -134,28 +134,6 @@ let%expect_test _ =
[%expect
{| "\132\149\166\190\000\000\000'\000\000\000\001\000\000\000\007\000\000\000\007\024_bigarr02\000\000\000\000\020\000\000\000\000\000\000\000(\000\000\000\001\000\000\000\005\000\003\000\003\000\001\000\002" |}]

let%expect_test _ =
let data =
"\132\149\166\189\r\022\206\021\001\147F\137d(\181/\253\000Xm\000\0000\n\
\000\000'\016c\001\000\012\135\007E"
in
let ocaml_5_1 =
match String.split_on_char '.' Sys.ocaml_version with
| major :: minor :: _ ->
let major = int_of_string major and minor = int_of_string minor in
major > 5 || (major = 5 && minor >= 1)
| _ -> assert false
in
let s =
(* This would only work on OCaml 5.1.0 if we were not linking
against compiler-libs *)
if ocaml_5_1 && not (Sys.win32 || Sys.cygwin)
then Marshal.from_string data 0
else String.make 10000 'c'
in
Printf.printf "%s ... (%d)\n" (String.sub s 0 20) (String.length s);
[%expect {| cccccccccccccccccccc ... (10000) |}]

let%expect_test "test sharing of string" =
let s = "AString" in
let p = s, s in
Expand Down
31 changes: 31 additions & 0 deletions compiler/tests-jsoo/test_marshal_compressed.ml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
(* Js_of_ocaml tests
* http://www.ocsigen.org/js_of_ocaml/
* Copyright (C) 2019 Shachar Itzhaky
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, with linking exception;
* either version 2.1 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*)

let%expect_test _ =
let data =
"\132\149\166\189\r\022\206\021\001\147F\137d(\181/\253\000Xm\000\0000\n\
\000\000'\016c\001\000\012\135\007E"
in
let s =
if Compression.compression_supported
then Marshal.from_string data 0
else String.make 10000 'c'
in
Printf.printf "%s ... (%d)\n" (String.sub s 0 20) (String.length s);
[%expect {| cccccccccccccccccccc ... (10000) |}]

0 comments on commit 3a082a7

Please sign in to comment.