Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate arity between compilation units #1594

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Propagate arity between compilation units #1594

wants to merge 7 commits into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Apr 8, 2024 •
edited
Loading

PoC for #550

  • Store immutability property of blocks
  • Try to recover some immutability info from debug events. (currently assuming modules are immutable, need to check what happens with recursive modules
  • Use this info to compute an approximated shape for registered globals.
  • Use shape info to compute function arity across compilation units (this is currently only done when compiling cma files as we know the shape of previously compiled units inside the library)

TODOs/Questions:

  • check the behavior with recursive modules
  • fix with effects
  • update global_flow ?
  • better mechanism for shape propagation ?-
  • store shape in a different file ? yes
  • should the "shape" file be given jsoo on the command line or should it look for it on the file system ? both
  • update dune rules with additional deps (WIP Jsoo shapes ocaml/dune#10767)

@hhugo hhugo requested a review from vouillon April 8, 2024 09:59
@hhugo
Copy link
Member Author

hhugo commented Apr 8, 2024

@vouillon, feel free to comment, review and even commit the branch.

vouillon
vouillon reviewed Apr 17, 2024
View reviewed changes
compiler/lib/flow.ml Outdated Show resolved Hide resolved
vouillon
vouillon reviewed Apr 17, 2024
View reviewed changes
compiler/lib/flow.ml Outdated Show resolved Hide resolved
vouillon
vouillon reviewed Apr 17, 2024
View reviewed changes
compiler/lib/flow.ml Outdated Show resolved Hide resolved
vouillon
vouillon reviewed Apr 17, 2024
View reviewed changes
compiler/lib/shape.ml Outdated Show resolved Hide resolved
@hhugo hhugo force-pushed the shapes branch 2 times, most recently from ffe3e43 to c7c009b Compare April 18, 2024 07:58
@hhugo hhugo mentioned this pull request Jun 7, 2024
Merged
@hhugo hhugo force-pushed the shapes branch 3 times, most recently from ce02188 to f8138d0 Compare July 26, 2024 12:12
@hhugo hhugo mentioned this pull request Jul 26, 2024
Draft
@vouillon vouillon mentioned this pull request Oct 4, 2024
Open
@hhugo hhugo force-pushed the shapes branch 3 times, most recently from b17b2f0 to 1ed2368 Compare October 26, 2024 06:45
@hhugo hhugo force-pushed the shapes branch 2 times, most recently from 14fe546 to 3821d45 Compare November 7, 2024 09:37
@hhugo
Compiler: propagate arity across unit boundary
ae7a6e4 
Propagate shape information through the flow analysis

Function arity from shapes: take advantage of flow analysis
@hhugo
control write-shape
83c00a1
@hhugo hhugo marked this pull request as ready for review November 19, 2024 14:35
@hhugo hhugo changed the title PoC: Propagate arity between compilation units Propagate arity between compilation units Nov 19, 2024
@hhugo
Copy link
Member Author

hhugo commented Nov 19, 2024

@vouillon, I think we could merge this before we have the support merged inside dune.
Would you want to give it another round of review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vouillon vouillon vouillon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhugo @vouillon