Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text encode decode #1645

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Text encode decode #1645

wants to merge 3 commits into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jul 26, 2024

No description provided.

@hhugo
Copy link
Member Author

hhugo commented Jul 26, 2024

I'd like to benchmark this change

@vouillon
Copy link
Member

vouillon commented Aug 1, 2024

One should create the encoder and the decoder only once and reuse it, and use a fixed buffer for caml_jsstring_of_string.

@hhugo
Copy link
Member Author

hhugo commented Aug 2, 2024

One should create the encoder and the decoder only once and reuse it, and use a fixed buffer for caml_jsstring_of_string.

Done

@hhugo
Copy link
Member Author

hhugo commented Aug 30, 2024

@vouillon, any idea on how to benchmark this other that micro benchmarks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhugo @vouillon