Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: compact indirect call #1647

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Compiler: compact indirect call #1647

merged 2 commits into from
Jul 26, 2024

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jul 26, 2024 •
edited
Loading

@hhugo hhugo merged commit 21c3c07 into master Jul 26, 2024
16 of 17 checks passed
@hhugo hhugo deleted the indirect-call branch July 26, 2024 12:03
@vouillon
Copy link
Member

Have you benchmarked this? From what I remember, it was slower.
See #1397 (comment)

@hhugo
Copy link
Member Author

hhugo commented Jul 26, 2024

Have you benchmarked this? From what I remember, it was slower. See #1397 (comment)

I've done some quick benchmark and it was slower to use E.call(null). Maybe we need more testing here.

@hhugo
Copy link
Member Author

hhugo commented Jul 28, 2024

@vouillon, in case you want to play with some smallbenchmarks https://jsperf.app/test-call-vs-apply/93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhugo @vouillon