-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the tests for uncaught exceptions more portable #1652
Conversation
Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior |
7dd70b4
to
3d802b5
Compare
Sorry about that. Done |
Oops, unassigned myself by mistake. |
3d802b5
to
ce437b4
Compare
We were only building the code, not running it, though... |
I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though |
It's
It's possible that I only ran the byte version without argument, (not calling unregister) |
This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).