Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tests for uncaught exceptions more portable #1652

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

OlivierNicole
Copy link
Contributor

This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).

@hhugo
Copy link
Member

hhugo commented Jul 30, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

@OlivierNicole
Copy link
Contributor Author

Sorry about that. Done

runtime/stdlib.js Outdated Show resolved Hide resolved
runtime/stdlib.js Outdated Show resolved Hide resolved
@OlivierNicole OlivierNicole removed their assignment Jul 31, 2024
@OlivierNicole
Copy link
Contributor Author

Oops, unassigned myself by mistake.

@vouillon
Copy link
Member

vouillon commented Aug 1, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

@hhugo
Copy link
Member

hhugo commented Aug 2, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

@hhugo
Copy link
Member

hhugo commented Aug 2, 2024

It's

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

It's possible that I only ran the byte version without argument, (not calling unregister)

@hhugo hhugo merged commit f014914 into ocsigen:master Aug 3, 2024
16 of 17 checks passed
@OlivierNicole OlivierNicole deleted the converge-jsoo-tip-04 branch August 20, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants