-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typing of typed arrays to support Wasm, and test Typed_array.Bytes #1656
Conversation
Turning the PR into a draft until the underlying PR is merged. |
56860f1
to
bcef604
Compare
bcef604
to
cd285d8
Compare
I rebased and marked the PR as ready for review. |
Any idea how much breakage the change of API generates ? |
It seems we could now complete the api with |
The PR definitely need a changelog entry |
I’m not sure. I suppose we could run an opam-health-check on the PR. |
This reverts commit 4e513ca.
It is unsound, see discussion in ocsigen#1656.
@OlivierNicole, can you look at Jerome suggestion ? and rebase and squash commits ? |
Oh, I was rebasing, but you merged before I could update the PR. |
In any case, thank you for the review and @vouillon for the explanations! |
I ended up squashing during the merge |
Note: This PR depends on #1649 and is based on top of it.
The feature change consists in the last two commits.edit: #1649 has been merged.This:
Typed_array
so that they work with the Wasm backend as wellTyped_array.Bytes
module.This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).