Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: format code with biome #1673

Merged
merged 2 commits into from
Sep 19, 2024
Merged

runtime: format code with biome #1673

merged 2 commits into from
Sep 19, 2024

Conversation

smorimoto
Copy link
Member

No description provided.

@hhugo
Copy link
Member

hhugo commented Sep 17, 2024

I'd prefer to not reformat the ts file (zstd.ts) because it's not maintained here.

@smorimoto
Copy link
Member Author

@hhugo Updated!

biome.json Show resolved Hide resolved
@TyOverby
Copy link
Collaborator

Could we avoid making big formatting changes until wasm_of_ocaml is merged?

@vouillon
Copy link
Member

Could we avoid making big formatting changes until wasm_of_ocaml is merged?

We are just going to copy the JavaScript runtime code without making any change, so this is not a problem.

@hhugo
Copy link
Member

hhugo commented Sep 19, 2024

Could we avoid making big formatting changes until wasm_of_ocaml is merged?

We are just going to copy the JavaScript runtime code without making any change, so this is not a problem.

@vouillon, why do you need such copy for wasm_of_ocaml?

@hhugo hhugo merged commit c25feb8 into master Sep 19, 2024
10 checks passed
@hhugo hhugo deleted the format-runtime branch September 19, 2024 07:54
@vouillon
Copy link
Member

What I mean is that we are going to directly use the version of the runtime files which are currently in the Js_of_ocaml repository rather than trying to merge them with those in the Wasm_of_ocaml repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants