-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add 32bit job for 4.14.2 #1698
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
You can rebase and should be able to drop the revert of targetint |
What is the error ? |
a1b3802
to
50f3c70
Compare
Actually sorry, I had installed the wrong X11 package for 32bit , so many packages to take care of. With this update, I think things are close to be ready, except for the test suite and the compilation failure on splay.ml Feel free to push to the branch directly as I'm not sure how to fix these issues myself. The compilation failure is:
Test suite I'm waiting for the full CI results as the failures might not be the same in the expect tests. |
eae6d06
to
299225e
Compare
CI setup is IMO acceptable. Test suite requires work on 2/3 cases, but beyond my expertise I'm afraid. |
Why not add a job for OCaml 5.2 32bit ? |
I was actually thinking of that, it is a good idea IMO. I kind of refrained last minute as I have no JSOO + OCaml 5.x experience, so I thought it could be wise to make the 4.12+32bit CI work first. I am myself still on 4.14.x due to lack of That doesn't matter for the JSOO version of Coq, however I still use 4.14 as my base dev branch. But I'm really looking forward to try JSOO 5.x with coq / coq-lsp / jsCoq. |
I'm merging this one, feel free to open a new one to add 5.2 32bit to the ci |
A problem with 5.2 + 32bit is that it is a byte only distribution, so JSOO will be a bytecode build, and thus quite slow. Should we still go ahead with a byte-only CI? I managed to compile coq-lsp with 5.2 + 32bit tho, but seems like this will become a dead end for us soon as coq-lsp requires But at least it works now! |
Testing byte only with 5.2 seems to be a good addition |
Let's see how far this gets, likely we will need some extra setup but depexts got much better in Opam 2.2.