Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request event handling on BrowserContext #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

randall-coding
Copy link

Description

This is a small fix for handling request events. Request events come in through the BrowserContext object on the subscribe_event() function but the current rust code is expecting it on the Page object which cannot receive those events based on the current implementation.

For reference we can look at how playwright-java handles these events (in the BrowserContextImpl.java and PageImpl.java files). I think we are forced to do it this way based on what the playwright driver is sending to us, though I'm not 100% sure since I'm still learning this codebase.

My changes

I added request event handling to the imp/BrowserContext.rs class and updated all related files needed to catch and rely the event.

Warning

This contains code from another pull request that updates the driver version (see PR #26).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant