Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion-comment: add missing property category.node_id #960

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

pascal-botpress
Copy link
Contributor

Resolves #959


Before the change?

$.category.node_id is missing

After the change?

$.category.node_id is defined with type string

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@pascal-botpress pascal-botpress changed the title Patch 1 discussion-comment: add missing property category.node_id Sep 30, 2024
@wolfy1339
Copy link
Member

Can you please add a new example payload or update existing ones

@pascal-botpress
Copy link
Contributor Author

Sure, I've updated the existing example payloads

@wolfy1339 wolfy1339 enabled auto-merge (squash) October 3, 2024 23:58
@wolfy1339 wolfy1339 merged commit 049c104 into octokit:main Oct 3, 2024
6 checks passed
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 7.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pascal-botpress pascal-botpress deleted the patch-1 branch October 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: discussion-comment : $.category.node_id is missing
3 participants