Update build-on-pull.yml #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update's versions.
|
I am very sorry, I realized I should have made this a draft until I get the build to actually work. Very sorry, I am still new to git... |
|
@Inhishonor no worries! we are all learning here! Go ahead and mark it as ready whenever you are. :) |
Update Versions and add code to add the signing keys to the build.
|
@octoshrimpy Is the code that injects the signing keys right? I merely copied and pasted it from another action in this repo. I am not sure how the secrets are labeled within the secrets file. |
|
I believe that is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates all the versions in the build-on-pull.yml. Note, this does not actually make this action succeed. It only allows the build to start. The build then makes it about 3/4 of the way through and fails with a signing keys error. I am currently working on this, but I have not made much headway. My apologies @Ilithy for jumping in on this. Thanks!