Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
By saying a tag name can't have a space after the
:
, it fixes an issue in SASS where the wordscontent
,cursor
,filter
,font
, andmask
are marked as tag names.Alternate Designs
Attempts have been made to solve this in atom/language-sass, to no avail. This is the solution Atom used to fix it in their language.
Benefits
SASS will no longer confuse these valid property names with tag names.
Possible Drawbacks
This won't highlight properly if someone writes
cursor:default;
without using a space after the colon. At best, those people suffer the same downstream syntax highlighting we've all suffered with the last number of years. At worst, anyone who writes their CSS like that deserves to be locked up.Applicable Issues
atom/language-sass#226