Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream grammar issue #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix downstream grammar issue #4

wants to merge 1 commit into from

Conversation

cssinate
Copy link

@cssinate cssinate commented Feb 2, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

By saying a tag name can't have a space after the :, it fixes an issue in SASS where the words content, cursor, filter, font, and mask are marked as tag names.

Alternate Designs

Attempts have been made to solve this in atom/language-sass, to no avail. This is the solution Atom used to fix it in their language.

Benefits

SASS will no longer confuse these valid property names with tag names.

Possible Drawbacks

This won't highlight properly if someone writes cursor:default; without using a space after the colon. At best, those people suffer the same downstream syntax highlighting we've all suffered with the last number of years. At worst, anyone who writes their CSS like that deserves to be locked up.

Applicable Issues

atom/language-sass#226

By saying a tag name can't have a space after the `:`, it fixes an issue in SASS where the words `content`, `cursor`, `filter`, `font`, and `mask` are marked as tag names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant