Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send a limited number of jobs at a time to the cluster to avoid stressing it too much #24

Closed
wants to merge 2 commits into from

Conversation

kit-ty-kate
Copy link
Contributor

@talex5 would this help?

@talex5
Copy link
Contributor

talex5 commented Nov 3, 2020

Yes, but we do want it to use the cluster fully when the cluster isn't busy. Having 500 jobs at once is fine, as long as nothing else needs to use the cluster at the same time.

Another option might be to mark all revdeps jobs as non-urgent. But really, we need more priorities, e.g.

  1. ocaml-ci or opam-repo-ci main job (new commit pushed)
  2. opam-repo-ci revdeps
  3. ocaml-ci or opam-repo-ci update (rebuild due to an opam-repository merge, etc)
  4. health-check build
  5. base builder image update

@kit-ty-kate
Copy link
Contributor Author

Agreed. I opened #25 in the meantime to set all revdeps jobs as not urgent.

@talex5
Copy link
Contributor

talex5 commented Nov 16, 2020

Now that ocurrent/ocluster#88 this PR shouldn't be needed.

@kit-ty-kate kit-ty-kate deleted the lwt_pool branch November 18, 2020 17:16
@kit-ty-kate kit-ty-kate restored the lwt_pool branch December 17, 2021 17:50
@kit-ty-kate kit-ty-kate reopened this Dec 17, 2021
@kit-ty-kate
Copy link
Contributor Author

It looks like this proposal may be necessary to avoid taking more RAM than the host server can handle (e.g. when sending > 30_000 jobs at once)

@talex5
Copy link
Contributor

talex5 commented Dec 17, 2021

Worth a try. Though I'm not sure where all the memory is actually going. opam-repo-ci has memtrace support compiled in, so it might be an idea to turn that on and find out.

@kit-ty-kate kit-ty-kate changed the title Only send 125 jobs at a time to the cluster to avoid stressing it too much Only send a limited number of jobs at a time to the cluster to avoid stressing it too much Dec 18, 2021
@kit-ty-kate
Copy link
Contributor Author

kit-ty-kate commented Dec 18, 2021

for some reason this makes opam-repo-ci stop doing any work. /jobs shows all the jobs as (ready to start) but none are actually starting.
Something to do with the way ocurrent is handling caches maybe?

EDIT: nevermind, it was: ocurrent/ocurrent-deployer#92

@shonfeder shonfeder closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants