Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5+ is a multicore release #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dra27
Copy link
Contributor

@dra27 dra27 commented Jan 20, 2023

Partial fix (hopefully) for the problems being seen with lwt, etc.

@dra27
Copy link
Contributor Author

dra27 commented Jan 21, 2023

This is deployed on live at the moment, and has unblocked, say, Lwt. See also ocurrent/ocaml-version#58.

@dra27
Copy link
Contributor Author

dra27 commented Jan 21, 2023

Now that OCaml 5 is multicore, it's possible that a lot of this special-case trickery used for multicore isn't necessary. However, it's important if that's implemented to be sure that we don't lose the testing matrix... e.g. for Lwt, the main libraries should continue to be tested on 4.08-5.0 with lwt_domain only being tested on 5.0.

@tmcgilchrist
Copy link
Member

This explicit is_multicore code has been removed and should be handled correctly in solver-service / ocaml-ci. I've added a test in #73 to be more explicit about it.

It might also be useful to have some testing in ocaml-ci to ensure certain packages have stable Analysis results. LWT project being a good example which should have a solution for many older OCaml versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants