Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class hierarchy of NB2WProduct #130

Merged
merged 16 commits into from
Jan 14, 2025
Merged

Refactor class hierarchy of NB2WProduct #130

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
411d1da
Add type_key attribute to class NB2WProduct
ferrigno Jan 10, 2025
32ac00a
NB2WNumpyDataProduct class
burnout87 Jan 13, 2025
ba3ffbb
unexplainable import
burnout87 Jan 13, 2025
f88b492
proper class order
burnout87 Jan 13, 2025
f39c8db
raise exception and NB2WProduct as base query not to instantiate
burnout87 Jan 13, 2025
959d222
more test data
burnout87 Jan 13, 2025
785db3c
fix failing test_pass_comment
dsavchenko Jan 13, 2025
855c1fe
uris in all type_key
dsavchenko Jan 13, 2025
d80789e
adapted test
burnout87 Jan 13, 2025
d4460ed
adaptation to dedicated exception
burnout87 Jan 13, 2025
cce703e
binary product json
dsavchenko Jan 13, 2025
3107296
removed some debugging prints
burnout87 Jan 14, 2025
708fc37
missing type_key for NB2WProgressProduct
burnout87 Jan 14, 2025
1fa5e50
test more in depth
burnout87 Jan 14, 2025
01cab67
no need for type_key
burnout87 Jan 14, 2025
514f3dd
correct type_key for NB2WNumpyDataProduct
burnout87 Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dispatcher_plugin_nb2workflow/products.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ def write(self, file_name=None, overwrite=True, file_dir=None):

self.table_data.write(file_path, overwrite=overwrite, format='ascii.ecsv')


class NB2WProduct:

type_key = 'oda:DataProduct'

def __init__(self,
encoded_data,
data_product_type=BaseQueryProduct,
Expand Down
Loading