-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token annotation examples added to docs #102
token annotation examples added to docs #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! At first glance - looks good to me. Let's have @ferrigno assess it as the first immediate user.
You mention first then Are the two codes equivalent? If yes, why you propose two solutions? Which the advantages and drawbacks of one or the other? It is not clear if one needs to set the optional parameters to some values. |
@ferrigno Indeed both ways described in doc are equivalent, however the second way also provides token validation and token discovery method as extra options as it was stated in the doc. The first way is more low level implementation. I've extended the documentation. |
Can you provide an example of context file so that one can test locally the code and debug ? |
Actually, I would suggest that you drop the option |
You should add that the annotation enures that the token of the session is stored by the system in a json file called ".oda...." and then notebook will read it. However, the other methods are suitable to read the token outside of MMODA as in other documentation. |
I removed the method restriction.
I removed the pre-defined method and explained the usage. |
No description provided.