Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySqlSchemaAdapter.php #119

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update MySqlSchemaAdapter.php #119

merged 1 commit into from
Jul 12, 2024

Conversation

AntoineMarques
Copy link
Contributor

Generator/PhinxMySqlGenerator::getTableMigrationNewDatabase expects upper case keys.

A notice is thrown, then migration fails with message

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Odan\Migration\Adapter\Generator\PhinxMySqlGenerator::getAlterDatabaseCharset() must be of the type string, null given, called in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 194 and defined in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php:211
Stack trace:
#0 /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php(194): Odan\Migration\Adapter\Generator\PhinxMySqlGenerator->getAlterDatabaseCharset(NULL)
#1 /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php(150): Odan\Migration\Adapter\Generator\PhinxMySqlGenerator->getTableMigrationNewDatabase(Array, Array, Array)
#2 /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php(125): Odan\Migration\Adapter\Generator\PhinxMySqlGenerator->addChangeMethod(Array, Array, Array)
#3  in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 211

Fatal error: Uncaught TypeError: Argument 1 passed to Odan\Migration\Adapter\Generator\PhinxMySqlGenerator::getAlterDatabaseCharset() must be of the type string, null given, called in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 194 and defined in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 211

TypeError: Argument 1 passed to Odan\Migration\Adapter\Generator\PhinxMySqlGenerator::getAlterDatabaseCharset() must be of the type string, null given, called in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 194 in /app/vendor/odan/phinx-migrations-generator/src/Migration/Adapter/Generator/PhinxMySqlGenerator.php on line 211

`Generator/PhinxMySqlGenerator::getTableMigrationNewDatabase` expects upper case
@odan odan merged commit 8e06de3 into odan:master Jul 12, 2024
4 checks passed
@odan
Copy link
Owner

odan commented Jul 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants