Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeorm version update #111

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Typeorm version update #111

wants to merge 9 commits into from

Conversation

minseop6
Copy link

Hi @odavid
From typeorm version 0.3.x, connection manager is deprecated, So we must be used dataSource.
Please check the revised pr.

#107

@odavid
Copy link
Owner

odavid commented Jul 29, 2022

Hi @minseop6,

I apologize for the late response and I thank you for this contribution.
At this stage, I sadly came to realization that I cannot maintain this project anymore.

As for the PR itself...

  • The package was designed to be framework independent, so it can be used on top of Typeorm alone. Adding NestJS as dependency violates this design.
  • As far as I remember, Typeorm also changed the way repositories created (object literal instead of classes), so I am not sure how this PR really uses the BaseRepository/patches to the Repository.

I am really sorry that I cannot help more than that at this stage...

@micalevisk
Copy link

here's an up-to-date(?) fork: https://github.com/Aliheym/typeorm-transactional

@ckawell-sb
Copy link

ckawell-sb commented Sep 1, 2022

@odavid can you please deprecate this package on npm? Thank you for your work on this, no worries if you don't have the time to maintain it anymore. Looks like the forked package(s) can take over its role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants