Restore deploy-storybook job #2151
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 224 224
Lines 11396 11396
Branches 1722 1722
=========================================
Hits 11396 11396 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Looks good! I'm curious whether this will work without adding a new deploy key or something. On CircleCI we had to add an SSH key for this...
https://github.com/storybookjs/storybook-deployer#deploying-storybook-as-part-of-a-ci-service
| - name: Determine node version | ||
| run: | ||
| echo "NODE_VERSION=$(grep -oP 'node\K\d+' Dockerfile)" >> $GITHUB_ENV | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '${{ env.NODE_VERSION }}' | ||
| cache: yarn |
There was a problem hiding this comment.
I'm guessing this is just quicker than using our actual container via setup-docker-compose?
There was a problem hiding this comment.
Yep, for frontend only stuff this is faster than going through the whole docker setup process
|
Hrm... |
|
Looks like this is the issue (possibly in addition to needing a token or PAT?): storybook-eol/storybook-deployer#77 https://github.com/oddbird/Metecho/runs/6313167269?check_suite_focus=true |
Description
Restore the job that deploys to Storybook that was lost when migrating from CircleCI
From #2149 (comment)