Fixed infinite loop when changing portal visibility without having re…

…gions.
oddlama · Jun 15, 2021 · eb0e1b2 · eb0e1b2
1 parent 85cfd30
commit eb0e1b2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/vane-portals/src/main/java/org/oddlama/vane/portals/menu/SettingsMenu.java b/vane-portals/src/main/java/org/oddlama/vane/portals/menu/SettingsMenu.java
@@ -158,10 +158,10 @@ private MenuWidget menu_item_visibility(final Portal portal) {
 				return ClickResult.ERROR;
 			}
 
-			Portal.Visibility new_vis;
+			Portal.Visibility new_vis = portal.visibility();
 			// If regions is not installed, we need to skip group visibility.
 			do {
-				new_vis = event.getClick() == ClickType.RIGHT ? portal.visibility().prev() : portal.visibility().next();
+				new_vis = event.getClick() == ClickType.RIGHT ? new_vis.prev() : new_vis.next();
 			} while (new_vis.requires_regions() && !get_module().is_regions_installed());
 
 			portal.visibility(new_vis);