Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misspelling of framework #182

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix misspelling of framework #182

merged 1 commit into from
Jul 13, 2024

Conversation

neBM
Copy link
Contributor

@neBM neBM commented Jun 28, 2024

Closes #181

@oddstr13 oddstr13 changed the title fix: DOTNET_FRAMEWORD renamed to DOTNET_FRAMEWORK Fix misspelling of framework Jul 13, 2024
oddstr13
oddstr13 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Owner

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this misspelling had any functional implications, unless the env variable was set outside the build step somehow (non-existant variable in bash expands to an empty string)

@oddstr13 oddstr13 merged commit ba1c38f into oddstr13:master Jul 13, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jul 13, 2024
Open
1 task
@oddstr13 oddstr13 added the chore label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddstr13 oddstr13 oddstr13 approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible typo in action.yaml script
2 participants
@neBM @oddstr13