Migration to new runtimedetails approach (#2082)

api/odigos/v1alpha1/instrumentedapplication_types.go

@@ -36,9 +36,9 @@ type InstrumentationLibraryOptions struct {
 type ProcessingState string
 
 const (
-	ProcessingStateFailed    ProcessingState = "Failed"
-	ProcessingStateSucceeded ProcessingState = "Succeeded"
-	ProcessingStateSkipped   ProcessingState = "Skipped"
+	ProcessingStateFailed    ProcessingState = "Failed"    // Used when CRI fails to detect the runtime envs
+	ProcessingStateSucceeded ProcessingState = "Succeeded" // Indicates that CRI successfully processed the runtime environments, even if no environments were detected.
+	ProcessingStateSkipped   ProcessingState = "Skipped"   // Used when env originally come from manifest
 )
 
 // +kubebuilder:object:generate=true

cli/cmd/resources/instrumentor.go

@@ -191,6 +191,11 @@ func NewInstrumentorClusterRole() *rbacv1.ClusterRole {
 				Resources: []string{"instrumentationconfigs"},
 				Verbs:     []string{"create", "delete", "get", "list", "patch", "update", "watch"},
 			},
+			{
+				APIGroups: []string{"odigos.io"},
+				Resources: []string{"instrumentationconfigs/status"},
+				Verbs:     []string{"update"},
+			},
 		},
 	}
 }

common/envOverwrite/overwriter.go

@@ -181,3 +181,7 @@ func ValToAppend(envName string, sdk common.OtelSdk) (string, bool) {
 
 	return valToAppend, true
 }
+
+func GetPossibleValuesPerEnv(env string) map[common.OtelSdk]string {
+	return EnvValuesMap[env].values
+}

helm/odigos/templates/instrumentor/clusterrole.yaml

@@ -78,3 +78,9 @@ rules:
       - patch
       - update
       - watch
+  - apiGroups:
+      - odigos.io
+    resources:
+      - instrumentationconfigs/status
+    verbs:
+      - update

instrumentor/main.go

@@ -29,6 +29,7 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 
+	runtimemigration "github.com/odigos-io/odigos/instrumentor/runtimemigration"
 	"sigs.k8s.io/controller-runtime/pkg/cache"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/manager/signals"
@@ -152,6 +153,10 @@ func main() {
 
 	ctx := signals.SetupSignalHandler()
 
+	// This temporary migration step ensures the runtimeDetails migration in the instrumentationConfig is performed.
+	// This code can be removed once the migration is confirmed to be successful.
+	mgr.Add(&runtimemigration.MigrationRunnable{KubeClient: mgr.GetClient(), Logger: setupLog})
+
 	err = sdks.SetDefaultSDKs(ctx)
 
 	if err != nil {