[GEN-2079]: enhance tooltip positioning logic with useRef for better accuracy #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Elferink <[email protected]>
alonkeyval
reviewed
Dec 22, 2024
| if (top >= innerHeight / 2) top += -40; | ||
| if (left >= innerWidth / 2) left += -(textLen * 8); | ||
| if (top >= innerHeight / 2) top += -(popupRef.current?.clientHeight || 40); | ||
| if (left >= innerWidth / 2) left += -(popupRef.current?.clientWidth || Math.min((text?.length || 0) * 7.5, 300)); |
There was a problem hiding this comment.
It seems a little bit risky, did you try this with long text?
alonkeyval
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several enhancements to the
Tooltipcomponent in thefrontend/webapp/reuseable-components/tooltip/index.tsxfile. The changes focus on improving the tooltip's positioning logic and code maintainability.Key changes include:
Enhancements to Tooltip Positioning:
useRefandforwardRefto manage the tooltip's positioning more accurately using the actual dimensions of the tooltip element. [1] [2] [3]handleMouseEventfunction to use the tooltip's dimensions for positioning instead of relying on text length.Code Simplification: