[GEN-2084]: enhance AutocompleteInput with autoFocus #2044
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the functionality and usability of the
AutocompleteInputcomponent and its integration in theActionModal. The most important changes include adding autofocus to theAutocompleteInput, extending thePropsinterface, and increasing the maximum height of the options list.Enhancements to
AutocompleteInputcomponent:frontend/webapp/containers/main/actions/action-modal/index.tsx: AddedautoFocusattribute to theAutocompleteInputcomponent to improve user experience by focusing on the input field when the modal opens.frontend/webapp/reuseable-components/auto-complete-input/index.tsx: Extended thePropsinterface to includeInputHTMLAttributesfrom React, allowing for more flexible input attributes.frontend/webapp/reuseable-components/auto-complete-input/index.tsx: Added spread operator (...props) to pass additional input attributes to theStyledInputcomponent.Styling improvements:
frontend/webapp/reuseable-components/auto-complete-input/index.tsx: Increased the maximum height of the options list from348pxto500pxand adjusted the width calculation for better display of options.