-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rbac permissions for odiglet #2049
base: main
Are you sure you want to change the base?
Conversation
}, | ||
&corev1.Namespace{}: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this was not used and is leftover from the time we were calculating if workload is instrumented in odiglet
- pods | ||
- services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove service which is not used by odiglet
@@ -6,26 +6,25 @@ rules: | |||
- apiGroups: | |||
- "" | |||
resources: | |||
- configmaps | |||
- namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove namespaces - not used by odiglet
@@ -6,26 +6,25 @@ rules: | |||
- apiGroups: | |||
- "" | |||
resources: | |||
- configmaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made configmap role instead of clusterrole
- daemonsets/finalizers | ||
- deployments/finalizers | ||
- statefulsets/finalizers | ||
verbs: | ||
- update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finalizers are not modified by odiglet
- collectorsgroups | ||
- collectorsgroups/status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made collectorsgroup role instead of clusterrole. we should remove them and record the signals in instrumentationconfig (future PR)
- apiGroups: | ||
- odigos.io | ||
resources: | ||
- odigosconfigurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover from the time the config was a special CRD (and not configmap)
remove unused permissions and make some of them role instead of clusterrole