[GEN-2141]: remove instrumentation config modified-event batcher; update source-update logic #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create & Delete Source CRD via UI
…ntation rule hooks
…nation and source CRUD operations
…nce node handling
…useSourceCRUD hooks
…nd usePendingStore
…pending items logic in useSSE and usePendingStore
…e source-update logic
alonkeyval
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
frontend/kube/watchers/instrumentation_config_watcher.goandfrontend/webapp/hooks/sources/useSourceCRUD.tsfiles, focusing on removing unnecessary event batching for modified events and improving the source CRUD operations. The most important changes are summarized below:Removal of Modified Event Handling:
instrumentationConfigModifiedEventBatcherand related event handling logic frominstrumentation_config_watcher.go. [1] [2] [3] [4] [5]Improvements to Source CRUD Operations:
useSourceCRUDhook to includerefetchandremovePendingItemsfunctions, providing better handling of source updates. [1] [2]Documentation and Code Comments:
usePendingStoreto explain its purpose and usage, improving code readability and maintainability. [1] [2]