Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: collect pprof data from data-collection and gateway components when diagnose #2114

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: collect pprof data from data-collection and gateway components when diagnose #2114

wants to merge 24 commits into from

Conversation

AvihuHenya
Copy link
Contributor

No description provided.

@AvihuHenya AvihuHenya requested a review from tamirdavid1 January 1, 2025 11:42
tamirdavid1
tamirdavid1 reviewed Jan 1, 2025
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
cli/cmd/diagnose_util/profiling_util.go Outdated Show resolved Hide resolved
tamirdavid1
tamirdavid1 reviewed Jan 1, 2025
View reviewed changes
cli/go.mod Outdated Show resolved Hide resolved
@AvihuHenya AvihuHenya requested review from blumamir and removed request for blumamir January 1, 2025 16:11
RonFed
RonFed approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Making the pprof ports configurable could be nice but not a blocker.

autoscaler/controllers/datacollection/configmap.go Show resolved Hide resolved
cli/cmd/diagnose_util/profiling_util.go Outdated Show resolved Hide resolved
@BenElferink BenElferink added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirdavid1 tamirdavid1 tamirdavid1 approved these changes

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvihuHenya @RonFed @tamirdavid1 @BenElferink