Use instrumentation config for runtime details #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonFed
requested review from
damemi,
edeNFed,
blumamir,
BenElferink and
tamirdavid1
BenElferink
approved these changes
Jan 2, 2025
edeNFed
approved these changes
Jan 2, 2025
damemi
reviewed
Jan 2, 2025
instrumentor/controllers/instrumentationdevice/instrumentationconfig_controller.go
Outdated
Show resolved
Hide resolved
damemi
approved these changes
Jan 2, 2025
blumamir
approved these changes
Jan 4, 2025
| @@ -229,40 +229,9 @@ func analyzeRuntimeInfo(resources *OdigosSourceResources) *RuntimeInfoAnalyze { | |||
| } | |||
| } | |||
|
|
|||
| func analyzeInstrumentedApplication(resources *OdigosSourceResources) InstrumentedApplicationAnalyze { | |||
There was a problem hiding this comment.
Can we also remove InstrumentedApplicationAnalyze type now?
| return false | ||
| } | ||
|
|
||
| if len(oldIc.Status.RuntimeDetailsByContainer) != len(newIc.Status.RuntimeDetailsByContainer) { |
There was a problem hiding this comment.
The event filter claims to pass the event if the runtime details changed. here we only check for the length of the array, which is good for now, but we will need to also check the content once it can be updated
There was a problem hiding this comment.
Right, Added a comment about this
| } | ||
|
|
||
| func (i RuntimeDetailsChangedPredicate) Delete(e event.DeleteEvent) bool { | ||
| return false |
There was a problem hiding this comment.
what will cause odigos to remove the instrumentation device when an app is un-instrumented?
There was a problem hiding this comment.
Right! a great catch 🥇
Fixed 😄
instrumentor/controllers/instrumentationdevice/instrumentationconfig_controller.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentationConfigstatus.instrumentor/instrumentationdeviceto rely on instrumnentation config, This means that when we add our device as a resource we'll look at the instrumentationConfig to decide.envoverwriter_testas it becomes un-relevant and conflicts with these changes.workload-lifecyclechainsaw assertions to be based oninstrumentationConfig.language-changedeployment from theworkload-lifecycletest. This is done because a) The test requires the restart of theinstrumentorwhich is not the desired behavior and b) The instrumentationConfig is currently enforced to only set the runtime details once, hence we currently don't support this use case.