Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-2214]: add Tier and InstallationMethod fields to Describe Odigos #2185

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

BenElferink
Copy link
Contributor

Following up with a UI update in reference to #2184


This pull request introduces several changes to the frontend/graph and frontend/webapp components to add support for tier and installationMethod fields in the OdigosAnalyze structure. The most important changes include updates to the GraphQL schema, resolvers, and TypeScript definitions.

GraphQL Schema and Resolvers:

  • Added tier and installationMethod fields to the OdigosAnalyze struct in frontend/graph/generated.go and updated the corresponding complexity functions. [1] [2] [3]
  • Implemented resolver functions for the new tier and installationMethod fields in frontend/graph/generated.go.
  • Updated the OdigosAnalyze query to include the new fields in frontend/graph/generated.go. [1] [2]

TypeScript and GraphQL Queries:

  • Updated the OdigosAnalyze type definition to include tier and installationMethod in frontend/graph/model/models_gen.go and frontend/graph/schema.graphqls. [1] [2]
  • Modified the convertOdigosToGQL function to map the new fields in frontend/services/describe/odigos_describe/odigos_describe.go.
  • Extended the GraphQL query DESCRIBE_ODIGOS to fetch tier and installationMethod in frontend/webapp/graphql/queries/describe.ts.
  • Updated the useDescribeOdigos hook to handle the new fields in frontend/webapp/hooks/describe/useDescribeOdigos.ts.
  • Added tier and installationMethod to the OdigosAnalyze interface in frontend/webapp/types/describe.ts.

Copy link

@BenElferink BenElferink requested a review from blumamir January 11, 2025 13:04
@BenElferink BenElferink added enhancement New feature or request frontend labels Jan 11, 2025
@BenElferink BenElferink enabled auto-merge (squash) January 12, 2025 09:23
@BenElferink BenElferink merged commit c567fa9 into odigos-io:main Jan 12, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants