Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glFilter and mutex #3685

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Conversation

Goaman
Copy link

@Goaman Goaman commented Dec 10, 2024

No description provided.

@robodoo
Copy link

robodoo commented Dec 10, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@Goaman Goaman force-pushed the master-mysterious-egg-1-nby branch 7 times, most recently from e5fcbbf to f4f0233 Compare December 12, 2024 09:27
@Goaman Goaman changed the title DropMutex add glFilter and mutex Dec 12, 2024
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from 467dadd to 5cab1c7 Compare December 12, 2024 15:09
@Goaman Goaman force-pushed the master-mysterious-egg-1-nby branch 2 times, most recently from d4f0944 to 0e4e365 Compare December 16, 2024 09:36
addons/html_builder/static/src/builder/builder_helpers.js Outdated Show resolved Hide resolved
const customAction = getCustomAction();
const customActionLoad =
customAction?.actionId && actionsRegistry.get(customAction.actionId).load;
if (!customActionLoad) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we force 1 microTick all the time ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

const call = (fn, operationParams) => {
const shorthandApplyDefs = getOperations(getShorthandActions());
const customAction = getCustomAction();
const customApplyDefs = (customAction && getOperations([customAction])) || [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applyDefs ?

});
})
const results = await Promise.all(
customApplyDefs.map((applyDef) =>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

})
)
);
return zip(customApplyDefs, results).map(([applyDef, result]) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@Goaman Goaman force-pushed the master-mysterious-egg-1-nby branch 2 times, most recently from 4fda06a to d291012 Compare December 16, 2024 10:16
@Goaman Goaman force-pushed the master-mysterious-egg-1-nby branch from d291012 to 636471b Compare December 16, 2024 10:17
@FrancoisGe FrancoisGe merged commit 3a87deb into master-mysterious-egg Dec 16, 2024
@FrancoisGe FrancoisGe deleted the master-mysterious-egg-1-nby branch December 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants