add initial dropzone + use closest dropzone + cancel drop in sidebar #4022
+82
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-mysterious-egg-role-2
branch
3 times, most recently
from
8616399 to
7e8146e
Compare
robinlej
force-pushed
the
master-mysterious-egg-role-2
branch
from
7e8146e to
33a345c
Compare
loco-odoo
reviewed
Jan 31, 2025
| @@ -257,10 +258,12 @@ export class BuilderSidebar extends Component { | |||
|
|
|||
| undo() { | |||
| this.editor.shared.history.undo(); | |||
| this.editor.shared.dropzone.updateEmptyDropZone(); | |||
There was a problem hiding this comment.
I think this can probably be be done by using the normalize_handlers resource directly inside the dropzone plugin. As its also called at the start of the plugin, there is probably no need to call it in the onMounted 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.