Container selection management #4134
Merged
+206
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
fdardenne
force-pushed
the
mysterious-egg-dafl-1
branch
from
dd26dc7 to
c6e8ce3
Compare
FrancoisGe
reviewed
Feb 27, 2025
addons/html_builder/static/src/core/plugins/builder_options_plugin.js
Outdated
Show resolved
Hide resolved
fdardenne
force-pushed
the
mysterious-egg-dafl-1
branch
3 times, most recently
from
a7e79cf to
aaf59d2
Compare
FrancoisGe
reviewed
Feb 27, 2025
addons/html_builder/static/src/core/plugins/builder_options_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/image_gallery_option_plugin.js
Outdated
Show resolved
Hide resolved
addons/html_builder/static/src/plugins/image_gallery_option_plugin.js
Outdated
Show resolved
Hide resolved
fdardenne
force-pushed
the
mysterious-egg-dafl-1
branch
from
aaf59d2 to
fa23af4
Compare
Before when applying undo/redo the container restored the current target which is not always the target from the previous steps. Now we restore the container correctly when applying undo/redo. To do so, we store the container target on each step.
When an action delete an element which is the current target of the container, the container will fallback to the ancestor of the target. This commit also forbid to update the container when previewing.
fdardenne
force-pushed
the
mysterious-egg-dafl-1
branch
from
ea02904 to
1e2ab95
Compare
Updating the layout of an image gallery replaces all the images by cloned ones. In consequence we lose the container selection. Now when changing layout the image gallery restore the container selection to the cloned image equivalent to the one that was selected. The old website fallbacked the selection to the parent
fdardenne
force-pushed
the
mysterious-egg-dafl-1
branch
from
1e2ab95 to
32aba27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.