fix number inputs #4144
Merged
fix number inputs #4144
+140
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
robinlej
force-pushed
the
master-mysterious-egg-role-3
branch
2 times, most recently
from
8c1e114 to
a9c907d
Compare
If there is no border, `hasBorder` returns an empty string which triggers an error on `.match()`.
If you write "0 3 " in a number input, the last space creates an empty string which causes an error.
Only accept: - numbers 0-9 - `.` and `,` - `-` for negative values - spaces to separate multiple values
robinlej
force-pushed
the
master-mysterious-egg-role-3
branch
from
48ec8b5 to
f1f88bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasBorderreturns an empty string which triggers an error on.match().